The third pull request for Release0.2

 This time I try to search for an issue which is about a new topic for me. 

After looking around from GitHub, I find an interesting issue from screen-recorder repo. The project can be implemented to show the window, but there is an error message "Uncaught TypeError: Cannot destructure property 'dialog' of 'remote' as it is undefined. ". In order to analyze the error, I fork the repo and download all of the files. I find the variable dialog comes from the variable remote and the remote comes from the electron dependency. Next, I try to figure out what "electron" is. 

Electron is an open-source software framework developed and maintained by GitHub. It allows for the development of desktop GUI applications using web technologies: it combines the Chromium rendering engine and the Node.js runtime. When studying the document of Electron, I see an example of dialog.

Dialog example


Comparing the usage of dialog from the author, I think the error was caused by a reference error. So, I fix this error and test it again. It works well. 

Test


Wonderful. Then, I created a new branch and push the changes from the new branch to the forked repo. After that, I launch a pull request to the author from GitHub. 

Comments

Post a Comment

Popular posts from this blog

Practice git remote and git merge in lab4

Image
 This week I am practicing using git remote and git merge through adding a new feature to the project another classmate completed. The steps are as following. creating branches to work on new features and fix bugs working on code changes in another project you didn't write using  git remote  and sharing commits with  git push ,  git pull , and  git fetch using  git merge  and doing practice merges fixing merge conflicts First of all, I choose a repo in Realease0.1 submissions list . The repo was created by my classmate,  Alexander Hugh. I filed an issue and forked the repo.  Second, I clone the repo to my local host and create a branch named issue-17 to add a new feature. The new feature is about adding the ignore URL patterns to  to exclude URLs from our check based on a URL pattern file. I push the new changes to the fork repo when I fix the new feature.                    ...
Read more

Update the process about Release 0.4

 In the second blog of Release 0.4, I will update my process about my link check project . Until now, my link check project can test status of a single link and the status of all the links of a file. But it can't process a directory to check all the files which include the links. So, I decide to add this feature to my project. I create an issue in the repo of Github. During the studying of Javascript and C++ programming languages, I just know how to read a file. It is a new topic for me. So, I need to search for the resolution for reading a directory. After searching, I find that there are two ways to read a directory using JavaScript. One is "fs.readdir()". The other is "fs.readdirSync()".  The  fs.readdir() method  is used to asynchronously read the contents of a given directory. The callback of this method returns an array of all the file names in the directory. The options argument can be used to change the format in which the files are returned from the me...
Read more

Open source development course

 I'm Leon and a student of Computer Programming & Analysis program in Seneca College. I am taking OSD600 course of this semester in Toronto .   I am vey interesting in the open source. The course is my opportunity to know more things about it.  Open source development can provide us the opportunities to work with the developers around the world.  Open source technology and open source thinking also can benefit everyone, not only programmers. I want to study the open source tools and accumulate the development experience of real software project. I'm gonna search for commercial service development projects to understand the requirements of a business project. The GitHub trending repo I research is  Rocket.Chat . It is Open Source Solution for team communications.  Instant messaging is a widely used network application. I want to know how to develop this kinds of softwares. I'm gonna share my learning process with this course during this semester in my bl...
Read more